Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add new TS client lib to repo #2214

Merged
merged 20 commits into from
Aug 23, 2024
Merged

feature: add new TS client lib to repo #2214

merged 20 commits into from
Aug 23, 2024

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Aug 19, 2024 •
edited
Loading

Creates a new SDK for trieve to be used in TS/JS

Very much a WIP

Example ussage:

	const trieve = new TrieveSDK({
      apiKey: "tr-mKHF9sstPHQHcCbh6Qk6Uw54hx7uwDGU",
      datasetId: "c04c43d9-382d-4815-810d-b776904a7390",
    });
    const data = await trieve.search({
      query: "one",
      search_type: "hybrid",
    });

Methods:

@skeptrunedev
Copy link
Contributor

Should not get merged yet since some tests are not passing yet and there are still a lot of routes left to go

@SaraVieira SaraVieira marked this pull request as ready for review August 22, 2024 16:09
@SaraVieira SaraVieira changed the title [DO NOT MERGE] - Start work on new TS SDK new TS SDK Aug 22, 2024
skeptrunedev
skeptrunedev reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, not sure why lint for search and analytics is broken. Going to take a look at that and simplifying the commit history here then will merge.

@skeptrunedev skeptrunedev changed the title new TS SDK feature: add new TS client lib to repo Aug 22, 2024
@SaraVieira
Copy link
Contributor Author

Hm, these don't seem to run on main so they may be failing there too :/

@skeptrunedev
Copy link
Contributor

There was a merge in the commit history which took me a minute to fix. Should be in a good state now. Looking at CI again

@skeptrunedev
Copy link
Contributor

I may have mangled some things, but I removed files until it was in a state where CI actions could pass

@skeptrunedev skeptrunedev force-pushed the feat/trieve-sdk branch 2 times, most recently from 806e04b to 0915d59 Compare August 23, 2024 01:56
@skeptrunedev skeptrunedev merged commit af965d9 into main Aug 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

@drew-harris drew-harris Awaiting requested review from drew-harris

@cdxker cdxker Awaiting requested review from cdxker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaraVieira @skeptrunedev @cdxker